On 6 Jun 2014 22:49:28 -0400 "George Spelvin" <linux@xxxxxxxxxxx> wrote: > This was useful during development, and is retained for future regression > testing. > > GCC appears to have no way to place string literals in a particular > section; adding __initconst to a char pointer leaves the string itself > in the default string section, where it will not be thrown away after > module load. > > Thus all string constants are kept in explicitly declared and named > arrays. Sorry this makes printk a bit harder to read. At least the > tests are more compact. > > Signed-off-by: George Spelvin <linux@xxxxxxxxxxx> > --- > Persuading GCC to throw away *all* the self-test data after running > it was surprisingly annoying. Yeah. Props for making the attempt. > The one thing I'm not really sure about is what to do if the self-test > fails. For now, I make the module_init function fail too. Opinions? The printk should suffice - someone will notice it eventually. Using KERN_ERR to report a failure might help draw attention to it. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
