Hi Tejun, I have a question, the hip04 and hix5hd2 soc use the old version of IP, but they also have a new version of IP which support FBS and NCQ, and now the new one is used by a new soc. How can I distinguish them, use "hisilicon,hisi-ahci-vX" or just add "generic-ahci" string for the IP which is conformant with spec and has no special customization and issue? Any advices, thanks. Regards, Kefeng On 2014-6-10 17:51, kefeng.wang wrote: > NCQ feature is unsupported on hisilicon sata controller, so disable it. > This version of IP is used by hip04 and hix5hd2 soc. > > Signed-off-by: Kefeng Wang <kefeng.wang@xxxxxxxxxx> > --- > drivers/ata/ahci_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index ebe505c..0cfda8b 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -58,7 +58,7 @@ static int ahci_probe(struct platform_device *pdev) > } > > if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci")) > - hflags |= AHCI_HFLAG_NO_FBS; > + hflags = AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ; > > rc = ahci_platform_init_host(pdev, hpriv, &ahci_port_info, > hflags, 0, 0); > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
