Hi Sascha: Thanks for your comments. Yes, it is. That's is what I done in the V5 patch-set. The patch-set is almost done, would send out a moment later. Best Regards Richard Zhu -----Original Message----- From: Sascha Hauer [mailto:s.hauer@xxxxxxxxxxxxxx] Sent: Thursday, July 11, 2013 3:56 PM To: Zhu Richard-R65037 Cc: Richard Zhu; shawn.guo@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; jgarzik@xxxxxxxxx; tj@xxxxxxxxxx; rob.herring@xxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx Subject: Re: [v4 3/3] sata: imx: add ahci sata support on imx platforms Hi Richard, On Thu, Jul 11, 2013 at 07:50:50AM +0000, Zhu Richard-R65037 wrote: > Hi Sascha: > Sorry to make a mess on the usage of the private data. > The private data of "imx_ahci_pdev" platform device would be used to store ata_host point. > I shouldn't set imxpriv to the private data of "imx_ahci_pdev", so do > the wrong assignment of The private pointer of device. Please allocate your private data along with the platform_device in the probe function, then in the init callback you can use container_of() to get a pointer to the data. Also I would recommend you to request the necessary resources (clocks, regmap) in the probe function and not in the init callback. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
