(cc'ing Sergei) On Sun, May 12, 2013 at 12:13:46PM +0200, Vincent Pelletier wrote: > In my understanding, it should indeed go in the "if (cdb)" block, as it should > only be needed for ATAPI commands. I don't think lbam/lbah need to be set (or > if they do, it's a different issue), because they are set independently from > DMADIR in atapi_xlat (so ata_exec_internal_sg would have to set them > independently too, probably in the "if (cdb)" block). > > I've modified original patch to the attached one, and tested it: drive is > correctly recognised and data can be read from it. > > What would be needed to integrate this patch into the kernel ? > Also, why does atapi_dmadir default to disabled ? I'm very unfamiliar with > ata[pi], if there any drawback from enabling it by default to fix such > devices ? Patch looks correct to me but can you please put more detail into the description preferably with a link to this thread? As for why atapi_dmadir isn't enabled by default, my memory is extremely fuzzy now but ISTR it to be deprecated and cause issues with some devices. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
