On Wed, Jan 16, 2013 at 11:31:31AM -0500, Alan Stern wrote: > On Wed, 16 Jan 2013, James Bottomley wrote: > > > On Tue, 2013-01-15 at 17:20 +0800, Aaron Lu wrote: > > > This patch adds runtime pm support for sr. > > > > > > It did this by increasing the runtime usage_count of the device when: > > > - its block device is opened; > > > - the events checking is to run. > > > > > > And decreasing the runtime usage_count of the device when: > > > - its block device is closed; > > > - After the events checking is done. > > > > > > The idea is discussed in this mail thread: > > > http://thread.gmane.org/gmane.linux.acpi.devel/55243/focus=52703 > > > > > > Signed-off-by: Aaron Lu <aaron.lu@xxxxxxxxx> > > > > I'd like an ack from Alan Stern as well, please, but with that, you can > > add my acked-by. > > Aaron, have you checked whether this patch works okay when you play a > track on an audio-only CD on the computer? The block interface looks > okay but I'm not sure about the cdrom_device interface. Just verified it works OK with the whole patchset applied using 2 audio CDs. After the ODD has been put into zero power state, insert an audio cd. ODD will be resumed, gvfs will automatically mount the disc, and a dialog titled "Audio Disc" asks me what to do. Press OK, the rhythmbox application will get started. Press the Play button of rhythmbox, songs will start to play, and runtime_usage is 2. Eject the disc, the ODD will be put to zero power state some time later. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html