> -----Original Message----- > From: linux-leds-owner@xxxxxxxxxxxxxxx [mailto:linux-leds- > owner@xxxxxxxxxxxxxxx] On Behalf Of Jason Cooper > Sent: Wednesday, January 09, 2013 5:04 AM > To: Josh Coombs > Cc: cooloney@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > ide@xxxxxxxxxxxxxxx; rpurdie@xxxxxxxxx; linux ARM; jgarzik@xxxxxxxxx; > linux-leds@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] Allow Marvell SATA driver to work with > LEDS_TRIGGER_IDE_DISK > > On Tue, Jan 08, 2013 at 02:18:04PM -0500, Josh Coombs wrote: > > Would it make more sense to add a second trigger > > for SATA instead? > > I'll leave that up to the led guys, I just wanted to raise the point > that the driver could logically support other types of disks, and we > should come up with a migration path instead of adding capabilities > ad-hoc. I agree with Jason's suggestion. One more thing to consider. If we replace the name, 'ide-disk' or 'ide_disk' with general one, then we should change the value of 'default_trigger' under arch directory also. LED trigger works if the name is matched with trigger name of LED device. Thanks, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
