On 12/29/2012 05:16 AM, Tejun Heo wrote: > Hello, > > On Wed, Dec 26, 2012 at 09:42:14AM +0800, Aaron Lu wrote: >>> This is really a round-about way to find out the matching device and >>> it wouldn't work if the disk device nests deeper. Doesn't really look >>> like a good idea to me. >> >> I don't quite understand the 'disk device nests deeper' case, can you >> please elaborate? My understanding is, as long as the disk's part0 >> device has a parent, this function should work. For LLDs want to take > > Hmmm, maybe I misread but it looked like it wouldn't work if there are > intermediate nodes between the parent device and part0. It might not > happen for sata but I don't think it's a good idea to assume that the > part0 and hardware device are connected directly. > > In general, it's a quite roundabout way to do it. Let's just push it > through SCSI. That's how everything else is routed after all. It's > confusing to do this one differently. OK, thanks for the suggestion. I'll prepare v11 using the previous demonstrated way(adding the event_driven flag to scsi_device) to silence the poll. Best regards, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
