On Mon, Nov 26, 2012 at 01:55:25PM +0800, Aaron Lu wrote: > > Commit 66fa7f215 "libata-acpi: improve ACPI disabling" introdcued the > behaviour of disabling ATA ACPI if ata_acpi_on_devcfg failed the 2nd > time, but commit 30dcf76ac dropped this behaviour and this caused > problem for Dimitris Damigos, where his laptop can not resume correctly. > > The bugzilla page for it is: > https://bugzilla.kernel.org/show_bug.cgi?id=49331 > > The problem is, ata_dev_push_id will fail the 2nd time it is invoked, > and due to disabling ACPI code is dropped, ata_acpi_on_devcfg which > calls ata_dev_push_id will keep failing and eventually made the device > disabled. > > This patch restores the original behaviour, if acpi failed the 2nd time, > disable acpi functionality for the device(and we do not event need to > add a debug message for this as it is still there ;-). > > Reported-by: Dimitris Damigos <damigos@xxxxxxxxxxx> > Signed-off-by: Aaron Lu <aaron.lu@xxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> Jeff? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
