On 11/19/2012 10:56 PM, Tejun Heo wrote: > Hey, Aaron. > > On Mon, Nov 19, 2012 at 11:09:40AM +0800, Aaron Lu wrote: >>> What I'm confused about is what autopm does for devices w/o zpodd. >>> What happens then? Is it gonna leave power on for the device and, >>> say, go on to suspend the controller? But, how would that work for, >>> say, future devices with async notification for media events? >> >> Maybe we shouldn't allow autopm for such devices? > > Yeah, maybe. It would be nice to be able to automatically power off > disks and ports which aren't being used tho. Yes, we can do this. I'm just saying, if an ODD is using async notification, we probably shouldn't enable autopm for it at the moment. > >>> That said, I can't say the snooping is pretty. It's a rather nasty >>> thing to do. So, libata now wants information from the event polling >>> in block layer, but reaching for block_device from ata_devices is >>> nasty too. Hmmm... but aren't you already doing that to block polling >>> on a powered down device? >> >> I was feeling brain damaged by this for some time :-) >> >> Basically, only ATA layer is aware of the power off thing, and sr knows >> nothing about this(or it is not supposed to know this, at least, this is >> what SCSI people think) and once powered off, I do not want the poll to >> disturb the device, so I need to block the poll. I can't come up with >> another way to achieve this except this nasty way. >> >> James suggests me to keep the poll, but emulate the command. The problem >> with this is, the autopm for resume will kick in on each poll, so I'll >> need to decide if power up the ODD for this time's resume is needed in >> port's runtime resume callback. This made things complex and it also put >> too much logic in the resume callback, which is not desired. And even if >> I keep the ODD in powered off state by emulating this poll command, its >> ancestor devices will still be resumed, and I may need to do some trick >> in their resume callback to avoid needless power/state transitions. This >> doesn't feel like an elegant way to solve this either. >> >> So yes, I'm still using this _nasty_ way to make the ODD stay in powered >> off state as long as possible. But if there is other elegant ways to >> solve this, I would appreciate it and happily using it. Personally, I >> hope we can make sr aware of ZPODD, that would make the pain gone. > > I really think we need a way for (auto)pm and event polling to talk to > each other so that autopm can tell event poll to sod off while pm is > in effect. Trying to solve this from inside libata doesn't seem > right. The problem, again, seems to be figuring out which hardware > device maps to which block device. Hmmm... Any good ideas? A possible way of doing this is using pm qos. We currently have 2 pm qos flags, NO_POWER_OFF and REMOTE_WAKEUP, and we can add another one: NO_POLL, use it like the following: 1 Set the NO_POLL pm qos flag when the underlying driver thinks it is no longer necessary. In the ZPODD's case, it should be set when the device is to be powered off; 2 Clear it when poll is necessary again. In the ZPODD's case, when power is re-gained, this flag will be cleared. 3 In the disk_events_workfn, check if this flag is set, if so, simply return. The disk->driverfs_dev can be used to host the pm qos flag, ATA layer can access it through ata_device->sdev->sdev_gendev. Is this OK? Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
