On 11/13/2012 02:55 AM, Tejun Heo wrote: > On Fri, Nov 09, 2012 at 02:51:56PM +0800, Aaron Lu wrote: >> Since the ata acpi notification code introduced in commit >> 3bd46600a7a7e938c54df8cdbac9910668c7dfb0 is solely for ZPODD, and we >> now have a dedicated place for it, move these code there. >> >> And the add/remove_pm_notifier code is simplified a little bit that it >> does not check things like if the handle is NULL and if a corresponding >> acpi_device is there for the handle as they are guaranteed by the >> device_can_poweroff already. > > Please don't mix code movement with actual changes. It makes it > difficult to track what's going on. Oh, yes. But since add_pm_notifier code happens during ZPODD init time, and init now happens during first time probe instead of after SCSI device has been created, some changes are necessary when moving these code. Sorry for not describing these things clear, I'll update the changelog to reflect this next time. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
