On 11/02/2012 10:09 PM, Brian Norris wrote: > This relatively simple boiler-plate code is repeated in several platform > drivers. We should implement a common version in libata. > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > --- > v2: fix whitespace > drivers/ata/libata-core.c | 23 +++++++++++++++++++++++ > include/linux/libata.h | 4 ++++ > 2 files changed, 27 insertions(+) > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 611050d..7bf1199 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c [...] > @@ -6350,6 +6351,26 @@ int ata_pci_device_resume(struct pci_dev *pdev) > > #endif /* CONFIG_PCI */ > > +/** > + * ata_platform_remove_one- Platform layer callback for device removal A space before hyphen is needed. > + * @pdev: Platform device that was removed > + * > + * Platform layer indicates to libata via this hook that hot-unplug or > + * module unload event has occurred. Detach all ports. Resource > + * release is handled via devres. > + * > + * LOCKING: > + * Inherited from platform layer (may sleep). > + */ I actually meant indenting with tabs within the comment too. :-) WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
