On Fri, Nov 2, 2012 at 4:07 AM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> On 02-11-2012 11:46, Brian Norris wrote:
>
>> This relatively simple boiler-plate code is repeated in several platform
>> drivers. We should implement a common version in libata.
>
>
>> Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>
>> ---
>> drivers/ata/libata-core.c | 23 +++++++++++++++++++++++
>> include/linux/libata.h | 4 ++++
>> 2 files changed, 27 insertions(+)
>
>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 611050d..820e47f 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>
> [...]
>
>> @@ -6350,6 +6351,26 @@ int ata_pci_device_resume(struct pci_dev *pdev)
>>
>> #endif /* CONFIG_PCI */
>>
>> +/**
>> + * ata_platform_remove_one- Platform layer callback for device
>> removal
>> + * @pdev: Platform device that was removed
>> + *
>> + * Platform layer indicates to libata via this hook that hot-unplug
>> or
>> + * module unload event has occurred. Detach all ports. Resource
>> + * release is handled via devres.
>> + *
>> + * LOCKING:
>> + * Inherited from platform layer (may sleep).
>> + */
>> +int ata_platform_remove_one(struct platform_device *pdev)
>> +{
>> + struct ata_host *host = platform_get_drvdata(pdev);
>> +
>> + ata_host_detach(host);
>
>
> Indent with tabs, not spaces, as below.
I need to remind myself to run checkpatch.pl more often. Thanks for
pointing this out. Will send v2. (Also, patch 12 had a pre-existing
indentation problem; I'll fix it for the line I change.)
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
