Re: [PATCH 00/14] ahci/libata: clean up platform device removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 2, 2012 at 10:01 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> On Fri, Nov 02, 2012 at 12:46:14AM -0700, Brian Norris wrote:
>> (1) Allows ahci_platform to unbind a device from the driver. This is useful for
>>     allowing total power-off of the device, for instance.
>> (2) Adds ahci_platform ata_port_operations.host_stop() hook, so that
>>     platform-device exit() can power down the device at the appropriate point
>>     in the removal sequence.
>> (3) Adds a common ata_platform_remove_one() function so that we don't
>>     re-implement a simple host detach across many platform drivers
>> (4) Switches many platform drivers to the new .remove function from (3)
>
> I personally would have converted all drivers in one patch but I think
> either way is fine.  Other than the indentation thing, for all patches
> in this series.
>
>   Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks. I'll reply to the indentation patch with a v2.

>> P.S. A related but distinct issue: someting is still broken in the
>> ata_host_detach() function, for shutting down the host, spinning down disks,
>> etc. When I rmmod the driver or unbind the device, I get the following
>> failures, and the HDD doesn't spin down:
>
> That's because detaching the driver is handled basically as controller
> hot unplug.  By the time SCSI is noticing the SCSI devices are going
> away, the corresponding ATA devices are already away.  It's kinda
> natural to implement that way.  Is this an actual problem?

Yes. The HDD doesn't spin down. I'm removing the device because I want
some power savings, so I would expect to spin down the disk.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux