Hi, On 11/01/2012 05:51 AM, Tejun Heo wrote: > Hello, > > On Tue, Oct 30, 2012 at 03:04:17PM +0800, Aaron Lu wrote: >>> check_event() can retry. Just add a per-sr mutex which is try-locked >>> by sr_block_check_events() and grab it when entering zero power. >> >> Good suggestion. I didn't think about solving it this way. >> >> Many people suggest me that ZPODD is pure SATA/ACPI stuff, and should >> not pollute sr driver, so I was trying hard not to touch sr while >> preparing these patches, unless there is no other choice(like the >> blocking event interface). >> >> So I'm not sure if your suggestion is the way to go. >> >> James, what do you think? Is it OK if I add a mutex into the scsi_cd >> structure to do this? Of course I'll define this only under >> CONFIG_SATA_ZPODD. > > I don't think what James' and my suggestions are that different. Just > silence check_event() while zpodd is kicked in somehow. There's no Well, since sr is not supposed to know anything about ZPODD, I don't see another way to silence check_event() in ATA layer. What I hope to achieve is when zero power ready status is sensed in ATA layer, no more sr_check_events should be called, as that function will runtime resume the ODD. Thanks, Aaron > reason to synchronize across multiple subsystems. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
