> Agree. If NCQ does not imply support of this log page, we should > definitely refine the check condition used here. > > I suppose Shane will take care of this, but if he doesn't, I'll do that > at a later time. I tried word 78 bit 5(Hardware Feature Control) which does not work, it is 0 on my HDD sample with log 30h page 08h and DevSlp supported. Seems that word 78 bit 5 is only the sufficient condition, not the essential condition. Do you guys have suggestion? Quoting SATA spec: > Word 78: Serial ATA features supported > Bit 5 If bit 5 is set to one, then Hardware Feature Control is > supported (see 13.10). If bit 5 is cleared to zero, then Hardware > Feature Control is not supported and IDENTIFY DEVICE data > word 79 bit 5 shall be cleared to zero. > > If Hardware Feature Control is supported, then: > a) IDENTIFY DEVICE data word 78 bit 5 (see 13.2.1.18) shall be > set to one; > b) the SET FEATURES Select Hardware Feature Control subcommand > shall be supported (see 13.3.8); > c) page 08h of the Identify Device Data log (see 13.7.7) shall > be supported; Thanks, Shane -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
