Hi Tomasz, On Sat, Oct 13, 2012 at 4:20 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > Hi, > > On Tuesday 09 of October 2012 17:18:52 Vasanth Ananthan wrote: >> This patch adds a platform driver and I2C client driver for SATA PHY >> controller >> >> Signed-off-by: Vasanth Ananthan <vasanth.a@xxxxxxxxxxx> >> --- >> drivers/ata/Makefile | 2 +- >> drivers/ata/sata_exynos_phy.c | 303 >> +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 304 >> insertions(+), 1 deletions(-) >> create mode 100644 drivers/ata/sata_exynos_phy.c >> [ ... ] >> + >> + phy->init = sataphy_init; >> + phy->shutdown = sataphy_shutdown; >> + phy->priv_data = (void *)sataphy; >> + phy->dev = &pdev->dev; >> + >> + ret = sata_add_phy(phy, SATA_PHY_GENERATION3); >> + if (ret < 0) >> + goto err4; > > Do you have any warranties that phy callbacks won't get called before i2c > device probes and sets i2c_client? > >> + >> + ret = i2c_add_driver(&sataphy_i2c_driver); >> + if (ret < 0) >> + goto err5; >> + >> + platform_set_drvdata(pdev, phy); I shall register my i2c client driver before assigning the SATA PHY call backs. Would that guarantee the calling of phy callbacks after the i2c device probes? -- Vasanth Ananthan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
