On Wed, 5 Sep 2012, Aaron Lu wrote: > > > > That flag is badly named. Something like "insert_event_during_suspend" > > > > would be better. > > This flag means, the reason the device gets runtime resumed is due to > user as described by the above situation 2, not by software(e.g. by > sr_check_events). > > I don't quite understand insert_event_during_suspend mean here... It means: An insert event occurred while the device was suspended. > > > > And even so I don't see why you wouldn't > > > > want to suspend for example a drive with an inserted but unopened disk. > > > > > > I assume that Aaron wanted to handle the easiest case first. Adding > > > suspend/resume handling to the open/close routines can be done later. > > > > Sure, but this patch blocks that in contrast to just not implementing it. > > It's already implemented. I did it in scsi_cd_get/put. > > And the reason I didn't allow runtime suspend for medium inside and door > closed case are: > 1 ZPODD has a spec and it didn't allow that; In theory we should allow runtime suspend in this case too, but leave the power on. (Although in practice, turning the power off would probably work even though it may violate the spec.) > 2 It's not easy to implement. Imagine user just inserts a disc, and the > sr_suspend routine checks that door is closed so that it wants to > suspend the device. But actually, after user just inserts a disc, he > definitely wants to use the device, so it's not a good thing to do. And > if ZPODD is used, the device will be powered off instantly when the door > is closed, this is not good. That's why we have an autosuspend delay. Although for some reason the SCSI subsystem doesn't use it currently... We need to add a call to pm_runtime_use_autosuspend() in scsi_sysfs_add_sdev(). Likewise, the pm_schedule_suspend() call in scsi_runtime_idle() should be changed to pm_runtime_autosuspend(). And there should be calls to pm_runtime_set_autosuspend_delay() in the sd and sr drivers. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
