On Mon, Aug 27, 2012 at 6:36 AM, Huang, Shane <Shane.Huang@xxxxxxx> wrote:
>> To avoid attempting to enable on older devices, you will need an
>> appropriate test (ata_id_has_ncq perhaps?)
>
> So far I don't find better method to exclude old devices than yours.
>
>
>> As you figured out in the other email, I was referring to sata_settings
>
> I'm going to modify both sata_settings and ID[78].
Sounds good.
>> I just do not like programming the device, when power policy may
>> indicate otherwise.
>>
>> Most conservative is to leave devslp feature in reset state and not
>> touch device or host until power policy dictates it is time to program
>> host + device.
>
> OK, I'll move setting feature back to ahci_set_aggressive_devslp().
> I'm trying to avoid setting feature each time for every sleep to
> improve performance.
>
> Adding pp->device_devslp_enabled with the code below does not make
> much difference because it is still called for every sleep.
> Do you have good suggestion?
>
> Any should we also call setting feature to disable device DevSlp
> for each !sleep?
Well we want to issue the ATA command to the device at each -power
policy- transition, not for each aggressive sleep.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
