Re: [resend PATCH 5/5] libsas, ipr: cleanup ata_host flags initialization via ata_host_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/2012 11:06 PM, Dan Williams wrote:
> libsas and ipr pass flags to ata_host_init that are meant for the port.
> 
> ata_host flags:
> 	ATA_HOST_SIMPLEX	= (1 << 0),	/* Host is simplex, one DMA channel per host only */
> 	ATA_HOST_STARTED	= (1 << 1),	/* Host started */
> 	ATA_HOST_PARALLEL_SCAN	= (1 << 2),	/* Ports on this host can be scanned in parallel */
> 	ATA_HOST_IGNORE_ATA	= (1 << 3),	/* Ignore ATA devices on this host. */
> 
> flags passed by libsas:
> 	ATA_FLAG_SATA		= (1 << 1),
> 	ATA_FLAG_PIO_DMA	= (1 << 7), /* PIO cmds via DMA */
> 	ATA_FLAG_NCQ		= (1 << 10), /* host supports NCQ */
> 
> The only one that aliases is ATA_HOST_STARTED which is a 'don't care' in
> the libsas and ipr cases since ata_hosts from these sources are not
> registered with libata.
> 
> Cc: Brian King <brking@xxxxxxxxxx>
> Reported-by: Hannes Reinecke <hare@xxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  drivers/ata/libata-core.c     |   10 ++--------
>  drivers/scsi/ipr.c            |    3 +--
>  drivers/scsi/libsas/sas_ata.c |    5 +----
>  include/linux/libata.h        |    3 +--

Acked-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center




--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux