Hi, Andrew Lunn writes: > > This is what i was thinking too and thats why floated this version of patch. > > But as Andrew said, clk API support is enabled for them, but still they > > don't have a clk for sata. To get this working, there are two solutions: > > - Create dummy clk for sata for that platform, so clk_get doesn't fail. > > - Check for error before every call to clk APIs after clk_get(). > > > > Andrew favored the second one. Which means, even on platforms > > with clk API defined and clk enable required, if there are some issues > > with lookup table, and clk_get() fails, system may hang when registers > > are accessed. For this i favored first one. > > I'm not too sure how you are going to achieve 1) > > config SATA_MV > tristate "Marvell SATA support" > help > This option enables support for the Marvell Serial ATA family. > Currently supports 88SX[56]0[48][01] PCI(-X) chips, > as well as the newer [67]042 PCI-X/PCIe and SOC devices. > > So this driver can be used with anything which has a PCI(-X) or PCIe > bus, or Orion SoC and a few PowerPC SoCs. > > The SoCs are not too bad, we know which ones they are and we can add > dummy entries to their device tree. However, how do you want to handle > the PCI devices? Create the dummy entry somewhere in the middle of the > PCI core? > > Thought not. > AFAICT the PCI archs do not have HAVE_CLK enabled. Thus they will have a dummy clk API in place that provides the driver with a non-error clk_get() return value. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
