Hi,
Andrew Lunn writes:
> > -#if defined(CONFIG_HAVE_CLK)
> > hpriv->clk = clk_get(&pdev->dev, NULL);
> > - if (IS_ERR(hpriv->clk))
> > - dev_notice(&pdev->dev, "cannot get clkdev\n");
> > - else
> > - clk_enable(hpriv->clk);
> > -#endif
> > + if (IS_ERR(hpriv->clk)) {
> > + dev_err(&pdev->dev, "cannot get clkdev\n");
> > + return PTR_ERR(hpriv->clk);
> > + }
> > +
> > + clk_enable(hpriv->clk);
>
> Sorry, but still wrong.
>
> The clock is optional. If we can find a clock, turn it on. If not,
> keep going....
>
> You patch causes the missing clock to become a fatal error.
>
The clock API should accept NULL pointers as valid clocks and
treat them as NOP.
Thus drivers wouldn't have to worry about whether they actually got a
clock to manage or if their clocks are just dummies.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
