On Wed, Apr 18, 2012 at 5:10 AM, Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > On 04/17/2012 05:05 PM, Mark Lord wrote: >> >> On 12-04-17 04:57 PM, Jeff Garzik wrote: >>> >>> On 04/17/2012 04:48 PM, Mark Lord wrote: >>>> >>>> On 12-04-17 04:38 PM, Mark Lord wrote: >>>>> >>>>> Okay, so why isn't SATA hotplug working in linux-3.3.2 ? >>>>> I don't know when it stopped working, but it's a blooming pain in the >>>>> sysadmin. >>>>> >>>>> I need to hotplug a SATA drive into an AHCI port, >>>>> preferably without having to reboot first. >>>>> >>>>> Is there a patch available already for this regression? >>>> >>>> >>>> >>>> Answering my own question, this patch appears to address the issue. >>>> I'll test and report back again shortly: >>>> >>>> http://patchwork.ozlabs.org/patch/146326/ >>>> >>>> Odd that it's been sitting in various people's inboxes since 3.3-rc1 >>>> and hasn't been pushed out yet. >>> >>> >>> The vast majority of "hotpluggable" ports are not necessarily covered by >>> this patch. >> >> >> >> And what majority of ports are currently broken by linux-3.3 ? >> Any idea of what the offending commit may have been, >> so I can test against that and perhaps get it reverted then? >> >> So far, my sample of three systems are all broken with this kernel. >> That's definitely "regression" territory. :) > > > Right -- rather than breaking a bunch and fixing a few, we might just need > to revert the runtime pm stuff altogether. Hi Jeff, I'm working on the hotplug issue fix. How about below suggestion: 1) forbid port runtime pm by default, user can allow it on demand by sysfs interface 2) then driver to allow port runtime pm if it supports hotplug well ZPODD feature relies on port runtime suspend/resume to enter/exit zero power state. [PATCH v3 0/7] SATA ZPODD support https://lkml.org/lkml/2012/3/28/20 So we really need port runtime pm support. Thanks, Lin Ming > > Commits to look at include > > 966f1212e1ac5fe3ddf04479d21488ddb36a2608 > 33574d68ae41ccbc6686cfabd965c685285c58a0 > e90b1e5a6e04c8892007ff8db20ef6d4fbdb5402 > 9ee4f3933930abf5cc34f8e9d69fe0e08c18f602 > 5ef41082912bdfcb33fa53b8dba2ad17dea2ef90 > 9a6d6a2ddabbd32c07f6a38b659e5f3db319fa5a > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
