Re: [PATCH 14/24] libsas: prevent double completion of scmds from eh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 17, 2011 at 5:13 AM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
>   Perhaps this a material for a separate patch...

If it changed behavior maybe we'd want it as a separate bisection
point, or if this approach for silencing this type of warnings gets
nak'd.

[..]
>>  enum exec_status {
>> -       /* The SAM_STAT_.. codes fit in the lower 6 bits */
>> +       /* The SAM_STAT_.. codes fit in the lower 6 bits, alias some of
>> +        * them here to silence 'case value not in enumerated type'
>> warnings
>> +        */
>> +       __SAM_STAT_CHECK_CONDITION = SAM_STAT_CHECK_CONDITION,
>
>
>   Looks like you forgot to change the problematic *case* itself...

It was deliberate.  This is just an alias to get the 'value' in the
enum, but I think the real definition should be used in all cases.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux