On Tue, Dec 6, 2011 at 1:22 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: > > This warning code is really ugly. Can we just drop it? In my searching > of in kernel dts files, there's only 1 instance I have found (Versatile > AB watchdog) that would hit this. I do agree. Especially since we never got any input on whether it works or not. > If not, you don't need to handle irq_create_of_mapping return as that is > already always 0 for no irq or error. Yeah, I'd like to just remove NO_IRQ from the OF paths. Afaik, it hasn't worked as NO_IRQ before anyway, so even if the rest of the drivers end up continuing using NO_IRQ, the OF-enabled ones on ARM should just stop. There can't be many of those yet. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html