On 11/20/2011 09:07 AM, Borislav Petkov wrote:
Hi, I managed to cause the following build breakage on current -linus with the attached config: drivers/ata/libata-sff.c: In function ‘ata_pci_init_one’: drivers/ata/libata-sff.c:2538:3: error: implicit declaration of function ‘ata_pci_bmdma_prepare_host’ [-Werror=implicit-function-declaration] drivers/ata/libata-sff.c:2549:40: error: ‘ata_bmdma_interrupt’ undeclared (first use in this function) drivers/ata/libata-sff.c:2549:40: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors make[2]: *** [drivers/ata/libata-sff.o] Error 1 make[1]: *** [drivers/ata] Error 2 make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs.... due to the fact that CONFIG_ATA_BMDMA is not set. From where I'm standing this needs either stubs for the missing functions in the include/linux/libata.h header for the case where CONFIG_ATA_BMDMA is not set, or make CONFIG_ATA_SFF depend on CONFIG_ATA_BMDMA or select it or whatever makes most sense.
The fix has been in libata-dev (and thus linux-next) for a couple days, and will go to Linus tonight or tomorrow.
Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
