Thanks, That was a good catch. I had that extra struct for another revision of the RDC peripheral integrated into the Vortex86DX. I removed it when I moved it to the pata_rdc.c driver but forgot the struct. The it821x driver works for the RDC drivers when DMA is turned off. But the RDC driver is the more logical choice. I will make the fix and send out the new patch. I accidentally sent this through the gmail interface with html on, Some of you may get this email twice. Thanks, Paul Schilling On Sun, Oct 23, 2011 at 3:20 AM, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote: > > Paul Schilling wrote: > > This fixes a DMA issue related to a CRC bug on > > the RDC pata peripherial found on the vortex86sx and vortex86dx. > > > > Signed-off-by: Paul Schilling <paul.s.schilling@xxxxxxxxx> > > --- > > drivers/ata/pata_it821x.c | 22 ++++++++++++++++++---- > > drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++----- > > drivers/ide/it821x.c | 9 +++++++-- > > include/linux/pci_ids.h | 2 ++ > > 4 files changed, 51 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c > > index c5532b9..5f8a54a 100644 > > --- a/drivers/ata/pata_it821x.c > > +++ b/drivers/ata/pata_it821x.c > > @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const > > struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = { > > .flags = ATA_FLAG_SLAVE_POSS, > > .pio_mask = ATA_PIO4, > > - .mwdma_mask = ATA_MWDMA2, > > + .mwdma_mask = 0, > > + .udma_mask = 0, > > + /* No UDMA */ > > + .port_ops = &it821x_rdc_port_ops > > + }; > > + static const struct ata_port_info info_rdc_01 = { > > + .flags = ATA_FLAG_SLAVE_POSS, > > + .pio_mask = ATA_PIO4, > > + .mwdma_mask = 0, > > + .udma_mask = 0, > > /* No UDMA */ > > .port_ops = &it821x_rdc_port_ops > > }; > > Why do you define this if it is never used? > > Eike -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html