On 10/13/2011 07:12 AM, Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx> Subject: [PATCH] pata_pcmcia/ide-cs: move IDs table to<linux/pata_pcmcia_ids.h> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx> --- drivers/ata/pata_pcmcia.c | 74 +--------------------------------------- drivers/ide/ide-cs.c | 74 +--------------------------------------- include/linux/pata_pcmcia_ids.h | 70 +++++++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+), 143 deletions(-)
I'm torn... it is an obvious and simple consolidation, but I dislike dropping such a driver-specific turd in include/linux. I also wonder if we want to continue adding new IDs to ide-cs?
David, any opinions? I'm basically ok with any option: (a) take Bart's patch as-is (with your acked-by), (b) ignore the patch and set a no-new-ids policy for ide-cs, (c) other?
Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
