On 10/12/2011 07:03 AM, Alan Cox wrote:
+ /* This last case is _NOT_ ok */ + case 0x30: + printk(KERN_ERR "sil680: Clock disabled ?\n");pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?dev_ would be even better but that seems to be a separate thing. The existing patch is still a move in the right direction.
agreed x 2 To be specific, it should be dev_err(&pdev->dev -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
