> cmd646r1_bmdma_stop() just calls the standard ata_bmdma_stop() > helper and it has been the case since the driver introduction > by commit 669a5db ("[libata] Add a bunch of PATA drivers.") in > Aug 2006. The question that was asked before I seem to remember was whehter it should be using its own helper. As libata reads the status first it shouldn't so this seems ok But this should all be documented in the changelog or god knows how someone will figure it out in 18 months time if they end up bisecting to it. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html