Hi Sergei,
On Thu, Mar 24, 2011 at 18:34:26, Sergei Shtylyov wrote:
> Hello.
>
> On 24-03-2011 12:08, Nori, Sekhar wrote:
>
> >>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> >>> index 68fe4c2..276199d 100644
> >>> --- a/arch/arm/mach-davinci/da850.c
> >>> +++ b/arch/arm/mach-davinci/da850.c
> >>> @@ -373,6 +373,14 @@ static struct clk spi1_clk = {
> >>> .flags = DA850_CLK_ASYNC3,
> >>> };
> >>>
> >>> +static struct clk sata_clk = {
> >>> + .name = "sata",
> >>> + .parent =&pll0_sysclk2,
> >>> + .lpsc = DA850_LPSC1_SATA,
> >>> + .gpsc = 1,
> >>> + .flags = PSC_FORCE,
> >>> +};
> >>> +
> >>> static struct clk_lookup da850_clks[] = {
> >>> CLK(NULL, "ref", &ref_clk),
> >>> CLK(NULL, "pll0", &pll0_clk),
> >>> @@ -419,6 +427,7 @@ static struct clk_lookup da850_clks[] = {
> >>> CLK(NULL, "usb20", &usb20_clk),
> >>> CLK("spi_davinci.0", NULL, &spi0_clk),
> >>> CLK("spi_davinci.1", NULL, &spi1_clk),
> >>> + CLK("ahci", NULL, &sata_clk),
> >>> CLK(NULL, NULL, NULL),
> >>> };
>
> >> I'd put the above into a separate patch...
>
> > Why should addition of clock data not be in the same patch
> > as the one which adds platform resources etc? It is not a big
> > deal to change, but I would like to know why you request this.
>
> I didn't request anything, I just said what I'd have done. :-)
Okay. I guess I will keep it as is.
> I think modifying the DA8xx-common and DA850-specific files should better be
> done separately. Although in this case we're adding DA850 only device, so
> perhaps the added code in devices-da8xx.c should be enclosed into #ifdef?
Good point. Will add the #ifdef.
> >>> diff --git a/arch/arm/mach-davinci/include/mach/da8xx.h b/arch/arm/mach-davinci/include/mach/da8xx.h
> >>> index e4fc1af..aa6f08e 100644
> >>> --- a/arch/arm/mach-davinci/include/mach/da8xx.h
> >>> +++ b/arch/arm/mach-davinci/include/mach/da8xx.h
> >> [...]
> >>> @@ -65,6 +66,7 @@ extern unsigned int da850_max_speed;
> >>> #define DA8XX_GPIO_BASE 0x01e26000
> >>> #define DA8XX_PSC1_BASE 0x01e27000
> >>> #define DA8XX_LCD_CNTRL_BASE 0x01e13000
> >>> +#define DA850_SATA_BASE 0x01e18000
>
> >> It's used only in devices-da8xx.c -- shouldn't it be declared there?
>
> > Yes, will move. Base addresses for modules like LCD and MMCSD can be
> > moved as well - should be subject of some future clean-up patch.
>
> Yes, maybe I'll submit one...
Thanks for the help!
Regards,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
