On Tue, Mar 15, 2011 at 10:22:38PM +0100, Maxime Bizon wrote: > > From: Maxime Bizon <mbizon@xxxxxxxxxx> > > The ahci_pmp_attach() & ahci_pmp_detach() unmask port irq, but they > are also called during port initialization, before ahci host irq > handler is registered. On ce4100 platform, this sometimes triggers > "irq 4: nobody cared" message when loading driver. > > Fixed this by not touching the register if the port is in frozen > state, and mark all uninitialized port as frozen. > > Signed-off-by: Maxime Bizon <mbizon@xxxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> But just one nit. > - writel(pp->intr_mask, port_mmio + PORT_IRQ_MASK); > + > + /* > + * This may be called while we are still initializing the ahci > + * host, and interrupt handler is not yet registered at that > + * time. So don't mess with irq mask register unless the port > + * is actually enabled. > + */ Can you augment the comment so that it indicates that hardware IRQ mask shouldn't be modified while the port is frozen and pp->intr_mask will be restored when the port is thawed and note that the port starts frozen? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
