> Case when ffs return will never arise.This scenario is
> already been discussed
> on linuxppc-dev@xxxxxxxxxxxxxxxxx Please see below explanation:
> sata_fsl_error_intr() is called during device error.The
> mentioned scenario
> will never comes. It can be observed via code:-
> if (cereg) { --> cereg is set on command error.
> Means there is at least 1 device present.
This all relies on the hardware working properly, and
nothing else accidentally clearing the device 'error'
bit mask.
Being slightly defensive when the out of range value
causes an array subscript error seems sensible.
It isn't as though the code size or execution time
matters here.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
