On 05/07/10 02:33 PM, Jeff Garzik wrote:
On 07/05/2010 10:25 AM, Mark Lord wrote:
Enable use of hyphenated pattern ranges in glob_match(), similar to how
shell globbing works, and how developers might expect things to work.
Signed-off-by: Mark Lord <mlord@xxxxxxxxx>
---
Patch also attached, to get around ongoing mailer issues here.
Eventually, glob_match() will move out of libata into lib/string.c or
similar.
No issue with correctness... but where is the demonstrated need?
Did someone ask for this?
..
Not specifically. But since this will eventually end up as a kernel-wide
library function, somebody somewhere will eventually make the reasonable
assumption that it does globbing "in the usual way".
Adding the hyphenated ranges turned out to be almost trivial,
so I added it on and posted the patch.
I could also send you follow-on patches to use that feature
in the ata blacklists, if you like, saving a few more bytes hither and dither. :)
Speaking of this stuff.. how do we go about moving this function to /lib/strings.c ?
Can that be done via your git tree?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
