On Wed, Jun 30, 2010 at 03:17:05PM -0400, Jeff Garzik wrote: > On 06/30/2010 02:47 PM, Wolfgang Denk wrote: >> Dear Rupjyoti Sarmah, >> >> In message<3b928476b2fffdcf0694e5436e8a482f@xxxxxxxxxxxxxx> you wrote: >>> >>> I took the mainline kernel v2.6.35-rc3 and downloaded using the git >>> download link. >>> I created the patch on 6/24/2010 after doing a git pull. >> >> I don;t think that you used v2.6.35-rc3; using this version, I still >> get this: >> >> drivers/ata/sata_dwc_460ex.c:43:1: warning: "DRV_NAME" redefined >> In file included from drivers/ata/sata_dwc_460ex.c:38: >> drivers/ata/libata.h:31:1: warning: this is the location of the previous definition >> drivers/ata/sata_dwc_460ex.c:44:1: warning: "DRV_VERSION" redefined >> drivers/ata/libata.h:32:1: warning: this is the location of the previous definition >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_read': >> drivers/ata/sata_dwc_460ex.c:777: error: 'struct ata_port' has no member named 'ioaddr' >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_write': >> drivers/ata/sata_dwc_460ex.c:793: error: 'struct ata_port' has no member named 'ioaddr' >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_error_intr': >> drivers/ata/sata_dwc_460ex.c:844: error: 'struct ata_port_operations' has no member named 'sff_check_status' > > It looks like -your- build config is missing CONFIG_ATA_SFF or similar. > > If you actually look at include/linux/libata.h, you see that struct > ata_port_operations most definitely has a member named sff_check_status, > for example. Ditto ata_port and member ioaddr, etc. The driver doesn't depend on CONFIG_ATA_SFF in it's Kconfig file, but seems to require it at build time. Isn't that something that needs fixing in the driver? josh -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
