Hi, Thanks for your feedback. I submitted an updated version of this patch later. I tried to limit the lines within 80 characters. Regards, Rup -----Original Message----- From: Marek Vasut [mailto:marek.vasut@xxxxxxxxx] Sent: Tuesday, June 29, 2010 7:04 AM To: Rupjyoti Sarmah Cc: linux-ide@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; jgarzik@xxxxxxxxx; sr@xxxxxxx; linuxppc-dev@xxxxxxxxxx Subject: Re: [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission> Dne Pá 4. června 2010 14:26:17 Rupjyoti Sarmah napsal(a): > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. > > Signed-off-by: Rupjyoti Sarmah <rsarmah@xxxxxxxxxxxxxxxx> > Signed-off-by: Mark Miesfeld <mmiesfeld@xxxxxxxxxxxxxxxx> > Signed-off-by: Prodyut Hazarika <phazarika@xxxxxxxxxxxxxxxx> > --SNIP-- > + dev_err(ap->dev, "%s: Command not pending cmd_issued=%d " > + "(tag=%d) DMA NOT started\n", __func__, > + hsdevp->cmd_issued[tag], tag); Just a nitpick, but don't break strings if possible. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html