On Fri, Jun 25, 2010 at 4:26 PM, Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > On 06/25/2010 12:57 AM, Jassi Brar wrote: >> >> From: Jassi Brar<jassi.brar@xxxxxxxxxxx> >> >> Some AHCI implementations may use Vendor Specific HBA[A0h, FFh] >> and/or Port[70h, 7Fh] registers to 'prepare' for initialization. >> For that, the platform needs memory mapped address of AHCI registers. >> >> This patch adds the 'mmio' argument and reorders the call to >> platform init function. >> >> Signed-off-by: Jassi Brar<jassi.brar@xxxxxxxxxxx> >> --- >> drivers/ata/ahci_platform.c | 23 +++++++++++++---------- >> include/linux/ahci_platform.h | 2 +- >> 2 files changed, 14 insertions(+), 11 deletions(-) > > It is also possible that platforms may need the init to prep the MMIO area > for use? Anton, does this patch work for you, or introduce such a problem? IMO platforms that need such prep(setup iommu ?) have the option to do it in earlier machine init code, but platforms that need to access vendor specific regs have no way other than to duplicate ioremap. Btw, I see no impact on CNS3XXX. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
