On 06/24/2010 05:34 AM, Harry Zhang wrote: > In function ahci_store_em_buffer(), if the input (signed char*) buffer > contains negative data, the constructed 32-bit long message data may > be wrong. Explaining why it was wrong would be nice. Also is adding a comment explaining why the uchar pointer is needed. Nothing fancy, just simple /* avoid sign extension */ should do. Other than that, Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html