Marek Vasut <marek.vasut@xxxxxxxxx> writes: > Dne Út 18. května 2010 01:09:28 Marek Vasut napsal(a): >> This patch adds a driver for a harddrive attached to PXA address and data >> bus. Unlike pata_platform, this driver allows usage of PXA DMA controller, >> making the transmission speed 3x higher. > > Hey guys, all the issues pointed out should be addressed. See below. > Cheers! For the first iteration, you can have my : Reviewed-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> For the next iteration, it would be good to : - fix the error path in pxa_ata_probe() => if dmam_alloc_coherent() fails => if pxa_request_dma() fails - in pxa_ata_remove() => maybe call devm_iounmap() -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
