Re: [PATCH #NEXT] libata: add command name parsing for error output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert Hancock wrote:
This patch improve libata's output for error/notification messages to allow easier
comprehension and debugging:

When ATAPI commands issued through the SCSI layer fail, use SCSI functions
to print the CDB in human-readable form instead of just dumping out the CDB
in hex.

Print out the name of the failed command (as defined by the ATA specification)
in error handling output along with the raw register contents.

When reporting status of ACPI taskfile commands executed on resume, also output
the names of the commands being executed (or not) in readable form.

Since the extra data for printing command names increases kernel size slightly,
a config option has been added to allow disabling command name output
(as well as some of the error register parsing) for those highly sensitive to
kernel text size.

Signed-off-by: Robert Hancock <hancockrwd@xxxxxxxxx>

applied...  nice!

any chance you wanna work on filling out ata_msg_*/ATA_MSG_*?

Such a feature should permit people to change libata debugging output at runtime, on a per-port basis, via sysfs.

That's always been the ideal, and was the idea when ata_msg_* was originally added. Would _immensely_ help with debugging.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux