Hello Sergei, It looks like that the email client has added these whitespaces and alignment mess-up, as the original patch file has none of these issues. I will try using another email client and re-post the patch. Thanks, Ashish -----Original Message----- From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxxxxx] Sent: Wednesday, July 01, 2009 1:56 PM To: Kalra Ashish-B00888 Cc: linux-ide@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxx Subject: Re: [PATCH][v2] sata_fsl: Add asynchronous notification support Hello. ashish kalra wrote: > Enable device hot-plug support on Port multiplier fan-out ports > > Signed-off-by: Ashish Kalra <Ashish.Kalra@xxxxxxxxxxxxx> [...] > diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index > 94eaa43..5751145 100644 > --- a/drivers/ata/sata_fsl.c > +++ b/drivers/ata/sata_fsl.c > @@ -34,7 +34,7 @@ enum { > > SATA_FSL_HOST_FLAGS = (ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | > ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA | > - ATA_FLAG_PMP | ATA_FLAG_NCQ), > + ATA_FLAG_PMP | ATA_FLAG_NCQ | ATA_FLAG_AN), Why are you breaking the alignment? There's alos trailing whitespace here... > @@ -132,7 +132,7 @@ enum { > INT_ON_SINGL_DEVICE_ERR = (1 << 1), > INT_ON_CMD_COMPLETE = 1, > > - INT_ON_ERROR = INT_ON_FATAL_ERR | > + INT_ON_ERROR = INT_ON_FATAL_ERR | INT_ON_SNOTIFY_UPDATE | Trailing whitespace. > @@ -154,6 +154,7 @@ enum { > > DEFAULT_PORT_IRQ_ENABLE_MASK = IE_ON_FATAL_ERR | IE_ON_PHYRDY_CHG | > IE_ON_SIGNATURE_UPDATE | > + IE_ON_SNOTIFY_UPDATE | Again. > IE_ON_SINGL_DEVICE_ERR | IE_ON_CMD_COMPLETE, > > EXT_INDIRECT_SEG_PRD_FLAG = (1 << 31), @@ -1003,6 +1004,11 @@ > static void sata_fsl_error_intr(struct ata_port > *ap) > freeze = 1; > } > > + /* Handle SDB FIS receive & notify update */ > + if (hstatus & INT_ON_SNOTIFY_UPDATE) { > + sata_async_notification(ap); > + } And again -- on every line. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
