Sorry for the noise: I thought I needed that change to send ATA passthrough commands as root. The change is indeed useless and dangerous. Gwendal. On Mon, Jun 29, 2009 at 4:26 PM, Jeff Garzik<jeff@xxxxxxxxxx> wrote: > Alan Cox wrote: >> >> On Mon, 29 Jun 2009 14:24:25 -0700 >> Gwendal Grignou <gwendal@xxxxxxxxxx> wrote: >> >>> We can already send ATA specific commands using /dev/sd device files. >>> This patch allow to use /dev/sg device files as well. >> >> That seems a very very bad idea. The point of the filters is only to >> allow through commands that are safe for all users with read or write >> permission to use. >> >> Backdooring it with arbitary passthrough ATA12/ATA16 commands doesn't >> seem very wise. > > Indeed. This pretty much defeats the filter for all ATA commands, including > ones that can brick your drive. > > Jeff > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
