On Fri, Jun 26 2009, NeilBrown wrote: > On Fri, June 26, 2009 11:16 pm, NeilBrown wrote: > > On Fri, June 26, 2009 10:50 pm, Jens Axboe wrote: > >> On Fri, Jun 26 2009, Neil Brown wrote: > > > >>> But for now, please please please can we revert the change which made > >>> 'queue' appear in md and dm devices, (and loop and ...) and put these > >>> generic values somewhere ... generic? > >> > >> No we cannot, not without a time machine. 2.6.30 is released, so it's > >> too late to revert things like that, even if we wanted. > > > > Drat... for some reason I was thinking that it only came in in 2.6.31-rc. > > However it is only documented in ABI/testing, not ABI/stable ... if there > > is any value in that distinction, then it should be possible to move it?? > > > > No, wait. I was right. The addition of 'queue' to md/dm devices > happened post-2.6.30. So are the additions of physical_block_size etc. > So there is still time to put these in a properly generic place. Yes you are right, the commit date had me fooled. > Do you have a good reason for them going in /queue? Do you have a good reason for moving them? Im my opinion that makes the separation between ->make_request_fn and ->request_fn devices bigger. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
