Hi Sergei,
This is a very nice series and I would like to apply it immediately
but unfortunately there is quite a few issues to be addressed first..
On Wednesday 10 June 2009 20:44:45 Sergei Shtylyov wrote:
> Convert the driver's two dma_end() methods into clear_irq() methods -- the
> driver will now use the standard dma_end() method implementation, ide_dma_end().
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
>
> ---
> The patch is atop of ide-2.6.git 'for-next' branch.
>
> drivers/ide/cmd64x.c | 31 +++++++++++++++++--------------
> 1 files changed, 17 insertions(+), 14 deletions(-)
[...]
> @@ -226,11 +226,10 @@ static void cmd64x_set_dma_mode(ide_driv
> (void) pci_write_config_byte(dev, pciU, regU);
> }
>
> -static int cmd648_dma_end(ide_drive_t *drive)
> +static void cmd648_clear_irq(ide_drive_t *drive)
> {
> ide_hwif_t *hwif = drive->hwif;
> unsigned long base = hwif->dma_base - (hwif->channel * 8);
Don't we need to check whether hwif->dma_base is valid now?
Also shouldn't this patch be done after fixing core code first?
[IOW this should be patch #5.5]
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
