Document "ignore_hpa" module parameter and add a warning about possible HPA compatibility issue. This should fix bug #13365: http://bugzilla.kernel.org/show_bug.cgi?id=13365 To: Jeff Garzik <jgarzik@xxxxxxxxx> Reported-by: Jacob <fun2program8@xxxxxxxxx> Reported-by: Christopher Hogan <chris.c.hogan@xxxxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Cc: Robert Hancock <hancockrwd@xxxxxxxxx> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> --- If people are fine with the patch I can push it together with ide fixes for 2.6.30-rc8. Documentation/kernel-parameters.txt | 6 ++++++ drivers/ata/libata-core.c | 15 +++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) Index: b/Documentation/kernel-parameters.txt =================================================================== --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -1101,6 +1101,12 @@ and is between 256 and 4096 characters. If there are multiple matching configurations changing the same attribute, the last one is used. + libata.ignore_hpa= + [LIBATA] Ignore HPA limit + Format: { "0" | "1" } + 0 -- keep BIOS limits (default) + 1 -- ignore limits, using full disk + lmb=debug [KNL] Enable lmb debug messages. load_ramdisk= [RAM] List of ramdisks to load from floppy Index: b/drivers/ata/libata-core.c =================================================================== --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1472,6 +1472,16 @@ static int ata_set_max_sectors(struct at return 0; } +static inline void ata_hpa_warn(unsigned long long first_sector, + unsigned long long last_sector) +{ + printk(KERN_WARNING "*** possible compatibility issue:\n" + "*** sectors %llu-%llu may be inaccessible\n" + "*** if Host Protected Area is used for filesystem data\n" + "*** (please refer to \"ignore_hpa\" module parameter)\n", + first_sector, last_sector); +} + /** * ata_hpa_resize - Resize a device with an HPA set * @dev: Device to resize @@ -1521,12 +1531,13 @@ static int ata_hpa_resize(struct ata_dev if (!print_info || native_sectors == sectors) return 0; - if (native_sectors > sectors) + if (native_sectors > sectors) { ata_dev_printk(dev, KERN_INFO, "HPA detected: current %llu, native %llu\n", (unsigned long long)sectors, (unsigned long long)native_sectors); - else if (native_sectors < sectors) + ata_hpa_warn(sectors, native_sectors - 1); + } else if (native_sectors < sectors) ata_dev_printk(dev, KERN_WARNING, "native sectors (%llu) is smaller than " "sectors (%llu)\n", -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
