Pete Zaitcev wrote:
> On Sat, 16 May 2009 00:14:35 +0900, Tejun Heo <tj@xxxxxxxxxx> wrote:
>
>> @@ -834,12 +829,7 @@ static void ub_end_rq(struct request *rq
>> error = -EIO;
>> rq->errors = scsi_status;
>> }
>> - rqlen = blk_rq_bytes(rq); /* Oddly enough, this is the residue. */
>> - if (__blk_end_request(rq, error, cmd_len)) {
>> - printk(KERN_WARNING DRV_NAME
>> - ": __blk_end_request blew, %s-cmd total %u rqlen %ld\n",
>> - blk_pc_request(rq)? "pc": "fs", cmd_len, rqlen);
>> - }
>> + __blk_end_request_all(rq, error);
>> }
>
> I applaud this. We needed blk_end_this_mudafakin_request() for a long time.
> Why two underscores?
The ones with two underscores are to be called with queue lock held.
Ones without grab queue lock themselves.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
