On Tue, 14 Apr 2009 20:45:50 +0400 Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > Alan Cox wrote: > > > >>The libata driver has copied the code from the IDE driver which caused a post > >>2.4.18 regression on many HPT370[A] chips -- DMA stopped to work completely, > >>only causing timeouts. Now remove hpt370_bmdma_start() for good... > > > Do we need to move it rather than remove it though. I need to look at > > that a bit with my HPT370 and see what happens. I suspect that if we get > > a failed transfer we need to do the reset somewhere - > > Well, the driver does the reset in hpt370_bmdma_stop(), and even twice. > > > perhaps qc_issue before anything hits the chip for the command ? > > No idea. I think it's just not needed. Works for me Jeff on what testing I've done - although my controller is happy either way -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html