Jeff Garzik wrote:
Mark Lord wrote:
Someday I'll fix that, if you guys don't beat me to it.
I suppose we just need to issue the SET_MULTIPLE command from
the drive revalidation code.
IMO this would be a good idea to do, across many ATA devices.
IIRC there is at least one other chip that snoops the set-multiple
command, and sets internal chip parameters.
Thus, like SET FEATURES - XFER MODE, it seems wise to unconditionally
issue SET MULTIPLE for ATA devices, under the logic that it
more-thoroughly initializes the controller and device, ensuring we are
at a known state at all times.
Wanna do a patch? :) Although not the greatest code location, I'm
guessing ata_dev_read_id() would probably be the place... Ideally we
would have a post-IDENTIFY reset sequence function.
..
I agree with all of the above.
Except I have a certain other, eagerly anticipated,
patch to work on right now. :)
Perhaps afterwards, though I'm due to disappear into the embedded
world again for a while, a couple of weeks from now.
If anyone else feels the urge, please don't wait for me!
Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
