On Mon, Apr 13, 2009 at 1:18 AM, Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Yinghai Lu wrote: >> >> Impact: new features >> >> based on patch on >> http://marc.info/?l=linux-ide&m=116289338705418&w=2 >> >> 1. update the patch for 2.6.19 to latest upstream ( 2.6.28?) >> 2. fix shared sgpio to support several mcp55 + io55, so every mcp55 have >> seperate spinlock >> 3. use scratch_source as numbering of sgpio instead of address of struct, >> so could go through kexec/kdump >> >> v2: revert NV_ON and NV_OFF, so turn on Activity LED all the time when >> disk is idle. >> v3: use one timer per sgpio instead of per nv_host, so for mcp55+io55 >> system will use 2 timers >> instead of 6 timers. >> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> >> >> --- >> drivers/ata/sata_nv.c | 562 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 562 insertions(+) > > > Is this really over 500 LOC, just to blink some lights from the data xfer > hot path? :) > there is timer to blink the activity led. per sgpio, normally one for mcp55 and one for io55. data xfer hot path only set some status. YH -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html