Hello. yanhua wrote: The patch description wouldn't hurt, i.e. why this fixup is needed... > diff --git a/drivers/ide/amd74xx.c b/drivers/ide/amd74xx.c > index 77267c8..51b888f 100644 > --- a/drivers/ide/amd74xx.c > +++ b/drivers/ide/amd74xx.c The IDE patches should be posted to linux-ide mail list. > @@ -23,6 +23,11 @@ > > #define DRV_NAME "amd74xx" > > +static const char *am74xx_quirk_drives[] = { > + "FUJITSU MHZ2160BH G2", > + NULL > +}; > + > enum { > AMD_IDE_CONFIG = 0x41, > AMD_CABLE_DETECT = 0x42, > @@ -112,6 +117,20 @@ static void amd_set_pio_mode(ide_drive_t *drive, > const u8 pio) > amd_set_drive(drive, XFER_PIO_0 + pio); Your patches are seriously whitespace-damaged, i.e. all tabs seem to be collapsed to a single space. You'll have to find a way to avoid that... > } > > +static void amd_quirkproc(ide_drive_t *drive, const u8 pio) Have you tried to compile this? The quirkproc() method only has one parameter. > +{ > + const char **list, *m = (char *)&drive->id[ATA_ID_PROD]; > + > + for (list = am74xx_quirk_drives; *list != NULL; list++) > + if (strstr(m, *list) != NULL) { > + drive->quirk_list = 2; > + return; > + } > + > + drive->quirk_list = 0; > + > +} > + > static void amd7409_cable_detect(struct pci_dev *dev) > { > /* no host side cable detection */ > @@ -194,6 +213,7 @@ static void __devinit init_hwif_amd74xx(ide_hwif_t > *hwif) > static const struct ide_port_ops amd_port_ops = { > .set_pio_mode = amd_set_pio_mode, > .set_dma_mode = amd_set_drive, > + .quirkproc = amd_quirkproc, > .cable_detect = amd_cable_detect, > }; > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html