On Wednesday 08 April 2009 00:30:06 Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > - TRIM support ("discard" operation for SSD devices)
> > (David Woodhouse & Matthew Wilcox)
> >
> > Since this is a new feature and hasn't seen much testing with production
> > devices it is not enabled by default yet (requires use of "ide_core.trim=1"
> > kernel parameter).
>
>
> As noted by Matthew, this appears to be missing the requisite block support?
I had this nice feeling of missing some detail but I didn't have time to think
about it too much since I was rushing to get all changes integrated for the last
pre -rc1 pull request. Now it is late due to premature TRIM support... :)
However it is not all that bad since we can just leave things as they are for
now and disable TRIM support until block changes get merged with patch below.
[ I added it to the pull request. Sorry Linus, this is the best I can do ATM
before failing asleep -- if this is not acceptable I'll revisit pull request
tomorrow. ]
>From 316f69abbb73595d0950c56c3b293534056d112e Mon Sep 17 00:00:00 2001
From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Date: Wed, 8 Apr 2009 00:42:59 +0200
Subject: [PATCH] ide: disable TRIM until block layer support gets merged
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
drivers/ide/ide.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 7b7cd76..4ed66d0 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -178,11 +178,14 @@ EXPORT_SYMBOL_GPL(ide_pci_clk);
module_param_named(pci_clock, ide_pci_clk, int, 0);
MODULE_PARM_DESC(pci_clock, "PCI bus clock frequency (in MHz)");
+/* needs block layer support */
+#if 0
int ide_trim = 0;
EXPORT_SYMBOL_GPL(ide_trim);
module_param_named(trim, ide_trim, int, 0);
MODULE_PARM_DESC(trim, "TRIM support (0=off, 1=on)");
+#endif
static int ide_set_dev_param_mask(const char *s, struct kernel_param *kp)
{
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
